RE: [PATCH RESEND v4 net-next 07/14] net: enetc: differentiate phylink capabilities for pseudo-MAC and standalone MAC

[ ... ]

quoted

@@ -400,25 +401,42 @@ int enetc_phylink_create(struct enetc_ndev_priv

*priv, struct device_node *node,

quoted

 {

[ ... ]

quoted

+		if (!is_enetc_rev1(priv->si)) {
+			mac_caps |= MAC_5000FD | MAC_10000FD;
+			__set_bit(PHY_INTERFACE_MODE_10GBASER,
+				  pf->phylink_config.supported_interfaces);
+		}

[Severity: High]
The commit message explicitly states that 10GBASE-R mode is not supported yet
and is added simply as preparation.

Will advertising an unsupported interface mode to phylink in
enetc_phylink_create() cause it to accept configurations for it, leading to a
broken configuration state or a hard probe failure when it attempts to
configure the MAC and PCS?

As the commit message stated, this is simply preparation for 10GBASER mode.
The probe should fail if the phy-mode is set to "10gbase-r", which is a normal
behavior. No fixed are needed to be fixed for this.