Thread (2 messages) 2 messages, 2 authors, 9d ago

Re: [PATCH 3/7] net: sxgbe: handle descriptor ring allocation failures

From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-07-20 02:56:24

On Mon, Jul 20, 2026 at 10:47:47AM +0800, Chenguang Zhao wrote:
From: Chenguang Zhao <redacted>

sxgbe_open() ignores allocation failures and proceeds to program DMA with
invalid ring addresses. In addition, an RX allocation failure leaks all
TX descriptor rings allocated earlier. Check the return value and unwind
both ring types before disconnecting the PHY.
You are fixing two things here, so there should be two patches. We
want lots of small patches which are obviously correct, with good
commit messages. And if your change breaks something, a git bisect
gives more information.

    Andrew

---
pw-bot: cr
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help