Thread (7 messages) 7 messages, 3 authors, 7d ago

Re: [PATCH net-next v2 1/2] dt-bindings: net: Add Maxio MAE0621A PHY

From: Liu Changjie <hidden>
Date: 2026-07-17 09:26:35
Also in: linux-devicetree, lkml

Hi Krzysztof,
How did you address previous feedback?

If you ignore feedback, shall we ignore the patch?
You are right. I should have documented the disposition of Andrew's
comment in this patch's changelog below the --- separator, rather than
only in the cover letter. Sorry about that.

Andrew suggested allowing a value of 0 to disable CLKOUT and noted that
this could also be added later. I intentionally did not add 0 in v2. The
only setting I have tested on this PHY is 125 MHz, and public documentation
for page 0xa43, register 0x19 is not available, so I cannot yet verify the
register programming and reset requirements for disabling CLKOUT.

Andrew's comment:
  https://lore.kernel.org/r/1a02ef89-2608-44c4-847f-239d9b86c7ab@lunn.ch (local)

The deferral is recorded in the cover letter's Changes in v2 section:
  https://lore.kernel.org/r/MN0PR19MB609154F210DF84DCB29D3696ACC62@MN0PR19MB6091.namprd19.prod.outlook.com (local)

I did not intend to ignore the feedback; I deferred that optional extension
until it can be documented and tested properly. I will state this explicitly
in the per-patch changelog in any future revision.

Best regards,
Liu Changjie
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help