Re: [PATCH 1/3] mm: move internal mempolicy APIs to new internal header
From: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
Date: 2026-07-16 15:22:17
Also in:
linux-fsdevel, linux-iommu, linux-mm, linux-nfs, lkml, loongarch
On 7/16/26 16:30, Brendan Jackman wrote:
There are no external users for this surface, reduce the scope. Ulterior motive: a later patch will add an alloc_flags arg to some parts of this. Note it might seem like this could just go in internal.h, since it's pretty small, but actually it will eventually need to import page_alloc.h, we don't want to import that from internal.h so best to proactively created this header now.
Hmm, maybe it could just go to page_alloc.h then? After all this is just bunch of internal page allocation functions, which just take the mempolicy pointer?
quoted hunk ↗ jump to hunk
Signed-off-by: Brendan Jackman <jackmanb@google.com> --- MAINTAINERS | 1 + include/linux/gfp.h | 9 --------- mm/filemap.c | 2 ++ mm/mempolicy.c | 1 + mm/mempolicy.h | 31 +++++++++++++++++++++++++++++++ mm/shmem.c | 1 + mm/swap_state.c | 1 + 7 files changed, 37 insertions(+), 9 deletions(-)diff --git a/MAINTAINERS b/MAINTAINERS index 8813d5d7eb0c1..9cde99c259639 100644 --- a/MAINTAINERS +++ b/MAINTAINERS@@ -17068,6 +17068,7 @@ F: include/uapi/linux/mempolicy.h F: include/linux/migrate.h F: include/linux/migrate_mode.h F: mm/mempolicy.c +F: mm/mempolicy.h F: mm/migrate.c F: mm/migrate_device.cdiff --git a/include/linux/gfp.h b/include/linux/gfp.h index 872bc53f32ec8..e4e974a6e5f90 100644 --- a/include/linux/gfp.h +++ b/include/linux/gfp.h@@ -11,7 +11,6 @@ #include <linux/sched.h> struct vm_area_struct; -struct mempolicy; /* Helper macro to avoid gfp flags if they are the default one */ #define __default_gfp(a,b,...) b@@ -274,8 +273,6 @@ struct page *alloc_pages_node_noprof(int nid, gfp_t gfp_mask, unsigned int order #ifdef CONFIG_NUMA struct page *alloc_pages_noprof(gfp_t gfp, unsigned int order); struct folio *folio_alloc_noprof(gfp_t gfp, unsigned int order); -struct folio *folio_alloc_mpol_noprof(gfp_t gfp, unsigned int order, - struct mempolicy *mpol, pgoff_t ilx, int nid); struct folio *vma_alloc_folio_noprof(gfp_t gfp, int order, struct vm_area_struct *vma, unsigned long addr); #else@@ -287,11 +284,6 @@ static inline struct folio *folio_alloc_noprof(gfp_t gfp, unsigned int order) { return __folio_alloc_node_noprof(gfp, order, numa_node_id()); } -static inline struct folio *folio_alloc_mpol_noprof(gfp_t gfp, unsigned int order, - struct mempolicy *mpol, pgoff_t ilx, int nid) -{ - return folio_alloc_noprof(gfp, order); -} static inline struct folio *vma_alloc_folio_noprof(gfp_t gfp, int order, struct vm_area_struct *vma, unsigned long addr) {@@ -301,7 +293,6 @@ static inline struct folio *vma_alloc_folio_noprof(gfp_t gfp, int order, #define alloc_pages(...) alloc_hooks(alloc_pages_noprof(__VA_ARGS__)) #define folio_alloc(...) alloc_hooks(folio_alloc_noprof(__VA_ARGS__)) -#define folio_alloc_mpol(...) alloc_hooks(folio_alloc_mpol_noprof(__VA_ARGS__)) #define vma_alloc_folio(...) alloc_hooks(vma_alloc_folio_noprof(__VA_ARGS__)) #define alloc_page(gfp_mask) alloc_pages(gfp_mask, 0)diff --git a/mm/filemap.c b/mm/filemap.c index 1dbb4c6f824e9..0dd8e2a15d746 100644 --- a/mm/filemap.c +++ b/mm/filemap.c@@ -52,6 +52,7 @@ #include <asm/tlbflush.h> #include "internal.h" +#include "mempolicy.h" #define CREATE_TRACE_POINTS #include <trace/events/filemap.h>@@ -63,6 +64,7 @@ #include <asm/mman.h> +#include "mempolicy.h" #include "swap.h" /*diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 5720f7f54d942..31c4e9f49b5e9 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c@@ -119,6 +119,7 @@ #include <linux/memory.h> #include "internal.h" +#include "mempolicy.h" #include "page_alloc.h" /* Internal flags */diff --git a/mm/mempolicy.h b/mm/mempolicy.h new file mode 100644 index 0000000000000..d80fe4c559786 --- /dev/null +++ b/mm/mempolicy.h@@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* + * mm-internal API for mempolicy.c. Public API lives in + * include/linux/mempolicy.h. + */ +#ifndef __MM_MEMPOLICY_H +#define __MM_MEMPOLICY_H + +#include <linux/gfp.h> +#include <linux/mempolicy.h> + +#ifdef CONFIG_NUMA +struct folio *folio_alloc_mpol_noprof(gfp_t gfp, unsigned int order, + struct mempolicy *mpol, pgoff_t ilx, int nid); +#else +static inline struct folio *folio_alloc_mpol_noprof(gfp_t gfp, unsigned int order, + struct mempolicy *mpol, pgoff_t ilx, int nid) +{ + return folio_alloc_noprof(gfp, order); +} +#endif + +#define folio_alloc_mpol(...) alloc_hooks(folio_alloc_mpol_noprof(__VA_ARGS__)) + +unsigned long alloc_pages_bulk_mempolicy_noprof(gfp_t gfp, + unsigned long nr_pages, + struct page **page_array); +#define alloc_pages_bulk_mempolicy(...) \ + alloc_hooks(alloc_pages_bulk_mempolicy_noprof(__VA_ARGS__)) + +#endif /* __MM_MEMPOLICY_H */diff --git a/mm/shmem.c b/mm/shmem.c index 5071177059a96..69f561332bb93 100644 --- a/mm/shmem.c +++ b/mm/shmem.c@@ -41,6 +41,7 @@ #include <linux/swapfile.h> #include <linux/iversion.h> #include <linux/unicode.h> +#include "mempolicy.h" #include "swap.h" static struct vfsmount *shm_mnt __ro_after_init;diff --git a/mm/swap_state.c b/mm/swap_state.c index 5be825911e645..8ccd03c39a407 100644 --- a/mm/swap_state.c +++ b/mm/swap_state.c@@ -24,6 +24,7 @@ #include <linux/shmem_fs.h> #include <linux/sysctl.h> #include "internal.h" +#include "mempolicy.h" #include "swap_table.h" #include "swap.h"