Re: [PATCH v4 0/2] bpf, sockmap: handle spurious tcp_msg_wait_data() wakeup

On 7/16/26 6:24 PM, Nnamdi Onyeyiri wrote:

On Thu, Jul 16, 2026 at 09:30:30AM +0800, Jiayuan Chen wrote:

quoted

Please do not send a patch by replying to an old thread.

...

Please use a commit subject like "selftests/bpf: add selftest xxx" for the
selftest patch.

Sorry, I'll resubmit with these changes.
  

quoted

Please use existing test frameworks such as sockmap_basic.c or
sockmap_strp.c.

Just to clarify, do you mean I should add the new tests to one of these
existing files? Or that I should add a new file, but write the test in the
same way as sockmap_basic.c implements them?

Thanks!

Using existing files is enough I guess.


I didn't read your selftest files fully, but I don't think a selftest 
with 299+ lines  is a good idea for reproducing a single problem.

I think you should try to shorten it to a reasonable size, e.g., by 
reusing helpers.