Thread (5 messages) 5 messages, 2 authors, 1d ago

Re: [PATCH net 1/2] vxlan: require CAP_NET_ADMIN in the device netns for changelink

From: Fernando Fernandez Mancera <hidden>
Date: 2026-07-15 12:36:34
Also in: lkml, stable

On Wed, 15 Jul 2026 07:56:47 +0200, Doruk Tan Ozturk [off-list ref] wrote:
A tunnel changelink() operates on at most two netns, dev_net(dev) and
the sticky underlay netns vxlan->net. They differ once the device is
created in or moved to a netns other than the one the request runs in.
The rtnl changelink path checks CAP_NET_ADMIN only against dev_net(dev),
so a caller privileged there but not in vxlan->net can rewrite a vxlan
device whose underlay lives in vxlan->net.

vxlan_changelink() validates and applies the new configuration against
vxlan->net (vxlan_config_validate(vxlan->net, ...)) and can reopen the
underlay socket in that netns, so the same reasoning as the tunnel
changelink series applies here.

Gate vxlan_changelink() with rtnl_dev_link_net_capable(), at the top of
the op before any attribute is parsed, matching ipgre_changelink() and
the rest of the "require CAP_NET_ADMIN in the device netns for
changelink" series.

Found by 0sec automated security-research tooling (https://0sec.ai).

Fixes: 889ce937c98f ("vxlan: correctly set vxlan->net when creating the device in a netns")
Cc: stable@vger.kernel.org
Assisted-by: 0sec:multi-model
Signed-off-by: Doruk Tan Ozturk <redacted>
The patch makes sense to me but I believe the right fixes tag would be:

Fixes: 8bcdc4f3a20b ("vxlan: add changelink support")

Thanks,
Fernando.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help