Re: [PATCH] mctp: check register_netdevice_notifier() error in mctp_device_init()

Hi,

[PATCH] mctp: check register_netdevice_notifier() error in mctp_device_init()

Please include the target tree in the subject prefix. SInce this is for
the net tree, you want something like:

  [PATCH net] mctp: check ...

mctp_device_init() handles errors from rtnl_af_register() and
rtnl_register_many(), but ignores the return value of
register_netdevice_notifier(). If notifier registration fails, init
can still return success while the module is only partially initialized.

Check the notifier registration error and fail module init early.

The change itself looks good, thanks.

Fixes: d51705614f66 ("mctp: Handle error of rtnl_register_module().")

... but no newline between the fixes and signed-off-by (and other tags).

Also, make sure you CC all the necessary maintainers; you're getting a
nipa CI failure due to that.

With those addressed:

Acked-by: Jeremy Kerr <jk@codeconstruct.com.au>

Cheers,


Jeremy