Thread (2 messages) 2 messages, 2 authors, 15d ago

Re: [PATCH] phonet: check register_netdevice_notifier() error in phonet_device_init()

From: Rémi Denis-Courmont <hidden>
Date: 2026-07-14 17:31:57

Le maanantaina 13. heinäkuuta 2026, 10.52.12 Itä-Euroopan kesäaika Minhong He 
a écrit :
phonet_device_init() registers a netdevice notifier before calling
phonet_netlink_register(), but does not check whether notifier
registration succeeded. On failure, netlink setup still proceeds and
init may return success without the notifier in place.
Check the notifier registration error and unwind through
phonet_device_exit() on failure.
That will unregister a notifier that is not registered. While I believe that 
would fail safe, I am not sure if that is really considered proper by 
contemporary kernel coding standards.

-- 
Rémi Denis-Courmont
https://www.remlab.net/


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help