Thread (9 messages) 9 messages, 2 authors, 3d ago

Re: [PATCH net-next v7 4/4] net: pse-pd: realtek-pse-mcu: add UART transport

From: Oleksij Rempel <o.rempel@pengutronix.de>
Date: 2026-07-14 09:01:43
Also in: linux-devicetree, lkml

On Sun, Jul 12, 2026 at 07:22:50PM +0000, Jonas Jelonek wrote:
Add the serdev (UART) transport for the Realtek PSE MCU core. It registers
the MCU as a serdev device and provides the send/recv callbacks the core
uses to exchange the 12-byte frames, receiving asynchronously via the
serdev receive_buf callback.

The baud rate defaults to 19200 and can be overridden per board with the
"current-speed" property.

Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
...
+static int rtpse_mcu_uart_probe(struct serdev_device *serdev)
+{
...
+
+	fwnode_property_read_u32(dev_fwnode(dev), "current-speed", &speed);
+	serdev_device_set_baudrate(serdev, speed);
+	serdev_device_set_flow_control(serdev, false);
+	serdev_device_set_parity(serdev, SERDEV_PARITY_NONE);
Some of this functions will return errors, it will be good to get at
least warnings, even if we decide to go with best effort initialization.

Otherwise, LGTM, with this addressed you can add my:
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help