Re: [PATCH net V2] net: phy: motorcomm: read EEE abilities in yt8521_get_features()
From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-07-10 13:13:15
Also in:
imx, lkml
quoted hunk ↗ jump to hunk
@@ -2490,7 +2490,8 @@ static int yt8521_get_features(struct phy_device *phydev) /* add fiber's features to phydev->supported */ yt8521_prepare_fiber_features(phydev, phydev->supported); } - return ret; + + return ret ? ret : genphy_c45_read_eee_abilities(phydev);
Using a ? like this is very uncommon.
Please change it to the usual
if (ret < 0)
return ret;
return genphy_c45_read_eee_abilities(phydev);
It might also be better to put the test after
yt8521_get_features_paged() call, since that is the only place missing
the test.
Andrew
---
pw-bot: cr