Re: [PATCHv2 net-next 1/7] net: usb: centralize usbnet_cdc_zte_rx_fixup in usbnet
From: Manuel Ebner <hidden>
Date: 2026-07-09 12:37:40
Also in:
linux-usb, lkml
On Thu, 2026-07-09 at 14:01 +0200, Oliver Neukum wrote: I guess a couple suggestions got lost, that's ok.
quoted hunk ↗ jump to hunk
This helper is used by multiple drivers using usbnet. It is better to be provided by usbnet than one of them. Signed-off-by: Oliver Neukum <oneukum@suse.com> --- v2: - spelling issues - issue with lost synchronization with SPLIT packets drivers/net/usb/cdc_ether.c | 19 ------------------- drivers/net/usb/usbnet.c | 19 +++++++++++++++++++ 2 files changed, 19 insertions(+), 19 deletions(-)diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c index b4df32e18461..e688fb99c61d 100644 --- a/drivers/net/usb/cdc_ether.c +++ b/drivers/net/usb/cdc_ether.c@@ -404,25 +404,6 @@ static int usbnet_cdc_zte_bind(struct usbnet *dev, structusb_interface *intf) return status; } -/* Make sure packets have correct destination MAC address
Make sure packets have the correct destination MAC address
- * - * A firmware bug observed on some devices (ZTE MF823/831/910) is that the - * device sends packets with a static, bogus, random MAC address (event if
(even if the device ...
- * device MAC address has been updated). Always set MAC address to that of the - * device.
Always set the MAC address to the one of your device. Thanks Manuel
[...]