Re: [PATCH v6] net: gro: fix double aggregation of flush-marked skbs

Shiming Cheng (成诗明) wrote:

On Tue, 2026-07-07 at 11:16 -0400, Willem de Bruijn wrote:

quoted

External email : Please do not click links or open attachments until
you have verified the sender or the content.


Shiming Cheng wrote:

quoted

The skb_gro_receive_list() function is missing a critical safety
check
that exists in the skb_gro_receive() implementation. Specifically,
it
does not validate NAPI_GRO_CB(skb)->flush before allowing packet
aggregation, as of commit 0ab03f353d36 ("net-gro: Fix GRO flush
when receiving a GSO packet.").

It does not check .. as of commit .. ?

No, skb_gro_receive checkos NAP_GRO_CB(skb)->flush as of that commit.

Is this wording okay?

Commit 0ab03f353d36 ("net-gro: Fix GRO flush when receiving a GSO
packet.") added a flush check to skb_gro_receive(), but
skb_gro_receive_list() lacks the same validation.

As a result, packets marked with NAPI_GRO_CB(skb)->flush may still be
re-aggregated.

That sounds good to me, thanks.