Re: [PATCH net-next 2/6] net: stmmac: mediatek: add PERI_ETH_CTRLx register... | netdev

[PATCH net-next 0/6] net/stmmac: Add Mediatek MT8189 support · Louis-Alexis Eyraud <hidden> · 2026-07-07
[PATCH net-next 1/6] dt-bindings: net: mediatek-dwmac: add support for MT8189 SoC · Louis-Alexis Eyraud <hidden> · 2026-07-07
Re: [PATCH net-next 1/6] dt-bindings: net: mediatek-dwmac: add support for MT8189 SoC · Andrew Lunn <andrew@lunn.ch> · 2026-07-07
Re: [PATCH net-next 1/6] dt-bindings: net: mediatek-dwmac: add support for MT8189 SoC · Louis-Alexis Eyraud <hidden> · 2026-07-08
Re: [PATCH net-next 1/6] dt-bindings: net: mediatek-dwmac: add support for MT8189 SoC · Andrew Lunn <andrew@lunn.ch> · 2026-07-08
Re: [PATCH net-next 1/6] dt-bindings: net: mediatek-dwmac: add support for MT8189 SoC · Louis-Alexis Eyraud <hidden> · 2026-07-10
Re: [PATCH net-next 1/6] dt-bindings: net: mediatek-dwmac: add support for MT8189 SoC · Andrew Lunn <andrew@lunn.ch> · 2026-07-10
[PATCH net-next 2/6] net: stmmac: mediatek: add PERI_ETH_CTRLx register offset in platform data · Louis-Alexis Eyraud <hidden> · 2026-07-07
Re: [PATCH net-next 2/6] net: stmmac: mediatek: add PERI_ETH_CTRLx register offset in platform data · Maxime Chevallier <maxime.chevallier@bootlin.com> · 2026-07-07
Re: [PATCH net-next 2/6] net: stmmac: mediatek: add PERI_ETH_CTRLx register offset in platform data · Andrew Lunn <andrew@lunn.ch> · 2026-07-07
Re: [PATCH net-next 2/6] net: stmmac: mediatek: add PERI_ETH_CTRLx register offset in platform data · Louis-Alexis Eyraud <hidden> · 2026-07-08
[PATCH net-next 3/6] net: stmmac: mediatek: rename MT2712 and MT8195 variant methods · Louis-Alexis Eyraud <hidden> · 2026-07-07
Re: [PATCH net-next 3/6] net: stmmac: mediatek: rename MT2712 and MT8195 variant methods · Maxime Chevallier <maxime.chevallier@bootlin.com> · 2026-07-07
Re: [PATCH net-next 3/6] net: stmmac: mediatek: rename MT2712 and MT8195 variant methods · Louis-Alexis Eyraud <hidden> · 2026-07-08
[PATCH net-next 4/6] net: stmmac: mediatek: add support for TX clock output enable feature · Louis-Alexis Eyraud <hidden> · 2026-07-07
[PATCH net-next 5/6] net: stmmac: mediatek: add support for TX deallocation adjustment feature · Louis-Alexis Eyraud <hidden> · 2026-07-07
Re: [PATCH net-next 5/6] net: stmmac: mediatek: add support for TX deallocation adjustment feature · Maxime Chevallier <maxime.chevallier@bootlin.com> · 2026-07-07
Re: [PATCH net-next 5/6] net: stmmac: mediatek: add support for TX deallocation adjustment feature · Louis-Alexis Eyraud <hidden> · 2026-07-08
[PATCH net-next 6/6] net: stmmac: mediatek: add support for MT8189 SoC · Louis-Alexis Eyraud <hidden> · 2026-07-07

Re: [PATCH net-next 2/6] net: stmmac: mediatek: add PERI_ETH_CTRLx register offset in platform data

From: Louis-Alexis Eyraud <hidden>
Date: 2026-07-08 11:45:23
Also in: linux-arm-kernel, linux-devicetree, linux-mediatek, lkml

Hi Andrew

On Tue, 2026-07-07 at 14:45 +0200, Andrew Lunn wrote:

quoted

+	.peri_eth_ctrl_offset = MT8195_PERI_ETH_CTRL_BASE,

nitpick:

Could the naming be more consistent? offset vs base?

	Andrew

Ack. 

The commit description and subject also use offset terminology and not
base so better keep the consistency.

I'll rename this define to MT8195_PERI_ETH_CTRL_OFFSET in the v2
version and do the same for the MT8189 one in patch 6.

Regards,
Louis-Alexis

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help