On 02.07.26 20:19, Manuel Ebner wrote:

On Thu, 2026-07-02 at 16:25 +0200, Oliver Neukum wrote:

quoted

diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 5544af1f4aa5..7beea6d0e731 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c

@@ -2347,6 +2347,25 @@ void usbnet_cdc_status(struct usbnet *dev, struct urb *urb)
  	}
  }
  EXPORT_SYMBOL_GPL(usbnet_cdc_status);
+
+/* Make sure packets have correct destination MAC address

    /*
     * Make sure packets have the correct destination MAC address

This sort of puts me into a conundrum. Does networking code use
the short style of comments or not? The documentation says that it does.
I am fine either way, but I need a clear rule.

quoted

+ *
+ * A firmware bug observed on some devices (ZTE MF823/831/910) is that the
+ * device sends packets with a static, bogus, random MAC address (event if

  (even if the device ...

Understood

quoted

+ * device MAC address has been updated). Always set MAC address to that of the
+ * device.

Always set the MAC address to the one of your device.

Understood

	Regards
		Oliver