Thread (14 messages) 14 messages, 2 authors, 6d ago

Re: [PATCH net-next v11 02/12] enic: verify firmware supports V2 SR-IOV at probe time

From: Breno Leitao <leitao@debian.org>
Date: 2026-07-06 10:43:58
Also in: lkml

On Fri, Jul 03, 2026 at 11:08:51AM -0700, Satish Kharat wrote:
During PF probe, query the firmware get-supported-feature interface
to verify that the running firmware supports V2 SR-IOV. Firmware
version 5.3(4.72) and later report VIC_FEATURE_SRIOV via
CMD_GET_SUPP_FEATURE_VER. If the firmware does not support the
feature, set vf_type to ENIC_VF_TYPE_NONE and log a warning so the
admin knows a firmware upgrade is needed.

V2 VFs are only ever enabled later through the sysfs .sriov_configure
path (enic_sriov_configure()), which rejects ENIC_VF_TYPE_NONE before
calling pci_enable_sriov(); there is no probe-time auto-enable, so
firmware that lacks V2 support never exposes VFs.

VIC_FEATURE_SRIOV is assigned the explicit value 4 to match the
firmware ABI.  Slot 3 (firmware's VIC_FEATURE_PTP) is reserved with
a comment rather than a placeholder enum entry, since PTP is not
used by the upstream driver.

Suggested-by: Breno Leitao <leitao@debian.org>
Signed-off-by: Satish Kharat <satishkh@cisco.com>
Reviewed-by: Breno Leitao <leitao@debian.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help