On Thu, Jul 2, 2026 at 12:53 AM Paolo Abeni [off-list ref] wrote:

On 6/29/26 8:49 PM, Michael Chan wrote:

quoted

+     /* Only called when shutting down or FW reset with BNXT_STATE_OPEN
+      * cleared, so no concurrent access.  No protection needed.
+      */
+     for (i = 0; i < BNXT_MAX_CRYPTO_KEY_TYPE; i++) {
+             kctx = &crypto->kctx[i];
+             list_for_each_entry_safe(kid, tmp, &kctx->list, list) {
+                     list_del(&kid->list);
+                     kfree(kid);

Sashiko still complains about RCU rules violation here, and the complain
looks legit to me.

BNXT_STATE_OPEN is always cleared in this path and all in-flight kTLS
ops should have been drained during __bnxt_close_nic().  There can be
no concurrency and that's why RCU is not required here.  I can improve
the comment above the for loop to make it more clear.

Note that to streamline patch processing you are expected to reply to
sashiko comments outline why they are (not) legit.

I will review and respond to all Sashiko comments in the next day or
so.  Thanks.