Thread (13 messages) 13 messages, 4 authors, 7d ago

Re: [PATCH net-next v2 2/5] net: dsa: realtek: rtl8366rb: Switch to generic port_bridge* handlers

From: Linus Walleij <linusw@kernel.org>
Date: 2026-07-03 21:17:46

On Fri, Jul 3, 2026 at 3:24 PM Luiz Angelo Daros de Luca
[off-list ref] wrote:
quoted
+static int rtl8366rb_port_set_isolation(struct realtek_priv *priv, int port,
+                                       u32 mask)
+{
+       /* Bit 0 enables isolation so set this if we enable isolation
+        * any of the ports an clear it if we disable on all of them.
+        */
+       if (mask)
+               mask = RTL8366RB_PORT_ISO_PORTS(mask) | RTL8366RB_PORT_ISO_EN;
+
+       return regmap_write(priv->map, RTL8366RB_PORT_ISO(port),
+                           mask);
+}
As sashiko pointed out, set_insolation(...,0) actually disables it
instead of completely isolating it.
I would unconditionally isolate the ports as we will never need to disable it.
Yeah, I'm working on a follow-up patch to fix this!

Thanks,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help