Re: [PATCH net-next v2 3/3] af_unix: Clean up error handling in unix_listen()
From: Christian Brauner <brauner@kernel.org>
Date: 2026-07-03 13:18:02
Also in:
lkml
From: Christian Brauner <brauner@kernel.org>
Date: 2026-07-03 13:18:02
Also in:
lkml
To avoid the sort of bug that was just fixed going forward, switch to a style where `err = -E...;` instead happens right before the `goto`. (`err = other_function(...);` is not changed.) Then there is no spooky-action-at-a-distance between the `err` initialization and the `goto`, something which is easier to slip by code review. Signed-off-by: John Ericson <redacted>
Reviewed-by: Christian Brauner (Amutable) <brauner@kernel.org> -- Christian Brauner [off-list ref]