[PATCH net-next 04/12] net: dsa: qca8k: Drop replies with wrong sequence numbers
From: Luke Howard <hidden>
Date: 2026-07-03 07:30:54
Also in:
lkml
Subsystem:
networking drivers, networking [dsa], the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Vladimir Oltean, Linus Torvalds
From: Andrew Lunn <andrew@lunn.ch> A response with the wrong sequence number is likely to be a late arriving responses, which the driver has already given up waiting for. Drop it rather than signalling the complete. If the complete was signalled, this late response could take the place of the genuine reply which is soon to follow. Signed-off-by: Andrew Lunn <andrew@lunn.ch> --- drivers/net/dsa/qca/qca8k-8xxx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/dsa/qca/qca8k-8xxx.c b/drivers/net/dsa/qca/qca8k-8xxx.c
index b0cbe72c15b4c..3b3fe96016176 100644
--- a/drivers/net/dsa/qca/qca8k-8xxx.c
+++ b/drivers/net/dsa/qca/qca8k-8xxx.c@@ -185,9 +185,9 @@ static void qca8k_rw_reg_ack_handler(struct dsa_switch *ds, struct sk_buff *skb) /* We can ignore odd value, we always round up them in the alloc function. */ len *= sizeof(u16); - /* Make sure the seq match the requested packet */ - if (get_unaligned_le32(&mgmt_ethhdr->seq) == mgmt_eth_data->seq) - mgmt_eth_data->ack = true; + /* Make sure the seq match the requested packet. If not, drop. */ + if (get_unaligned_le32(&mgmt_ethhdr->seq) != mgmt_eth_data->seq) + return; if (cmd == MDIO_READ) { u32 *val = mgmt_eth_data->data;
--
2.43.0