[PATCH iwl-next v1 3/6] ixgbe: E610: do not disable LSE on driver down/remove
From: Jedrzej Jagielski <hidden>
Date: 2026-07-02 09:35:20
Also in:
intel-wired-lan
Subsystem:
intel ethernet drivers, networking drivers, the rest · Maintainers:
Tony Nguyen, Przemek Kitszel, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
For the first case: LSE especially shall remain enabled when interface is down and link watchdog cannot track status of the link. Then the only way for link update is by handling LSE. For the second case: There's no value in disabling LSE when the driver's unloading is about to be terminated. Reviewed-by: Aleksandr Loktionov <redacted> Signed-off-by: Jedrzej Jagielski <redacted> --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 18 ------------------ 1 file changed, 18 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index 2c8968b9b86c..f33a534490b5 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c@@ -5979,19 +5979,6 @@ static int ixgbe_enable_link_status_events(struct ixgbe_adapter *adapter) return ixgbe_configure_lse(&adapter->hw, true); } -/** - * ixgbe_disable_link_status_events - disable link status events - * @adapter: pointer to the adapter structure - * - * Disables link status events by invoking ixgbe_configure_lse() - * - * Return: the exit code of the operation. - */ -static int ixgbe_disable_link_status_events(struct ixgbe_adapter *adapter) -{ - return ixgbe_configure_lse(&adapter->hw, false); -} - /** * ixgbe_sfp_link_config - set up SFP+ link * @adapter: pointer to private adapter struct
@@ -6775,8 +6762,6 @@ void ixgbe_down(struct ixgbe_adapter *adapter) ixgbe_clean_all_tx_rings(adapter); ixgbe_clean_all_rx_rings(adapter); - if (adapter->hw.mac.type == ixgbe_mac_e610) - ixgbe_disable_link_status_events(adapter); } /**
@@ -12143,9 +12128,6 @@ static void ixgbe_remove(struct pci_dev *pdev) set_bit(__IXGBE_REMOVING, &adapter->state); cancel_work_sync(&adapter->service_task); - if (adapter->hw.mac.type == ixgbe_mac_e610) - ixgbe_disable_link_status_events(adapter); - if (adapter->mii_bus) mdiobus_unregister(adapter->mii_bus);
--
2.31.1