Re: [PATCH 3/4] mwifiex: debugfs: use kzalloc() to allocate formatting buffers
From: Francesco Dolcini <francesco@dolcini.it>
Date: 2026-07-01 16:24:18
Also in:
linux-mm, linux-wireless, lkml
From: Francesco Dolcini <francesco@dolcini.it>
Date: 2026-07-01 16:24:18
Also in:
linux-mm, linux-wireless, lkml
+Jeff Jeff: this is relevant also for nxpwifi. On Wed, Jul 01, 2026 at 04:59:12PM +0300, Mike Rapoport (Microsoft) wrote:
mwifiex debugfs functions allocate buffers for formatting debug output text using get_zeroed_page(). These buffers can be allocated with kmalloc() as there's nothing special about them to go directly to the page allocator. kmalloc() provides a better API that does not require ugly casts and kfree() does not need to know the size of the freed object. Performance difference between kmalloc() and __get_free_pages() is not measurable as both allocators take an object/page from a per-CPU list for fast path allocations. For the slow path the performance is anyway determined by the amount of reclaim involved rather than by what allocator is used. Replace use of get_zeroed_page() with kzalloc() and free_page() with kfree(). Link: https://lore.kernel.org/all/635405e4-9423-4a25-a6e7-e03c8ea0bcbe@redhat.com (local) Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Reviewed-by: Francesco Dolcini <redacted>