-----Original Message-----
From: Uwe Kleine-König <redacted>
Sent: Tuesday, June 30, 2026 10:08 AM
Subject: Re: [PATCH net-next v6 12/15] onsemi: s2500: Add driver support for TS2500
MAC-PHY

quoted

+static const struct spi_device_id s2500_ids[] = {
+	{ "s2500" },
+	{}

(i.e. use a named initializer, a space between { and } and no empty line
before MODULE_DEVICE_TABLE()).

Also the driver should probably have a

	MODULE_DEVICE_TABLE(of, s2500_of_match);

Best regards
Uwe

Thanks for your review. Will take care of your three comments
(space between {}, no empty line, missing MODULE_DEVICE_TABLE macro)