Re: [PATCH net] net: usb: net1080: validate packet_len before pad-byte access in rx_fixup

On Mon, Jun 29, 2026 at 6:54 PM Jakub Kicinski [off-list ref] wrote:

On Sat, 27 Jun 2026 14:28:54 -0700 Xiang Mei wrote:

quoted

      if ((packet_len & 0x01) == 0) {

just add "skb->len &&" to this condition?

Thanks for the review; your one-line patch is clearer.

v2 has been sent.

Xiang

quoted

+             if (packet_len >= skb->len) {
+                     dev->net->stats.rx_frame_errors++;
+                     netdev_dbg(dev->net, "bad packet len %d (expected %d)\n",
+                                skb->len, packet_len);
+                     nc_ensure_sync(dev);
+                     return 0;
+             }

--
pw-bot: cr