[PATCH 02/10] net: emac: fix sparse __iomem warnings in IAHT register access
From: Rosen Penev <hidden>
Date: 2026-06-30 04:16:40
Also in:
lkml
Subsystem:
networking drivers, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Annotate iaht1/iaht2 in the EMAC4 register union with __iomem so sparse does not warn about address-space mismatches, and simplify emac_xaht_base() to return &p->u1.emac4sync.iaht1 (or the EMAC4 variant) directly instead of computing the offset by hand. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev <redacted> --- drivers/net/ethernet/ibm/emac/core.h | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/ibm/emac/core.h b/drivers/net/ethernet/ibm/emac/core.h
index 46c5512c8e00..296da4bf3781 100644
--- a/drivers/net/ethernet/ibm/emac/core.h
+++ b/drivers/net/ethernet/ibm/emac/core.h@@ -399,17 +399,13 @@ static inline int emac_has_feature(struct emac_instance *dev, static inline u32 __iomem *emac_xaht_base(struct emac_instance *dev) { struct emac_regs __iomem *p = dev->emacp; - int offset; /* The first IAHT entry always is the base of the block of * IAHT and GAHT registers. */ if (emac_has_feature(dev, EMAC_FTR_EMAC4SYNC)) - offset = offsetof(struct emac_regs, u1.emac4sync.iaht1); - else - offset = offsetof(struct emac_regs, u0.emac4.iaht1); - - return (u32 __iomem *)((__force ptrdiff_t)p + offset); + return &p->u1.emac4sync.iaht1; + return &p->u0.emac4.iaht1; } static inline u32 __iomem *emac_gaht_base(struct emac_instance *dev)
--
2.54.0