Re: [PATCH net v2] net/sched: cake: reject overhead values that underflow length
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-06-29 22:42:29
Also in:
lkml
On Mon, 29 Jun 2026 14:44:28 -0400 Samuel Moelius wrote:
On Mon, Jun 29, 2026 at 1:24 PM Samuel Moelius [off-list ref] wrote:quoted
On Sat, Jun 13, 2026 at 5:26 PM Jakub Kicinski [off-list ref] wrote:quoted
On Tue, 9 Jun 2026 23:29:36 +0000 Samuel Moelius wrote:[...]quoted
quoted
Both Sashiko's complain - these values are neither safe nor sufficient. How was the -64 chosen? It looks suspiciously close the min ethernet frame length.That's how it was chosen. But as you've shown, it was not a good choice. I would like to submit a revised patch that does the check on the datapath, as you suggested. Should I send that patch? Or would you prefer to wait for a response from Toke?Apologies. I just noticed Toke did reply. Should I send a patch consistent with what he suggested?
Yes please