Re: [PATCH net-next v10 1/5] hinic3: Add ethtool queue ops
From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-06-29 14:25:26
Also in:
linux-doc, lkml
quoted hunk ↗ jump to hunk
@@ -315,21 +315,28 @@ static void hinic3_link_status_change(struct net_device *netdev, { struct hinic3_nic_dev *nic_dev = netdev_priv(netdev); + if (!mutex_trylock(&nic_dev->state_lock)) + return; + if (link_status_up) { if (netif_carrier_ok(netdev)) - return; + goto err_unlock;
So ignoring a link status change, leaving the carrier set wrongly, because some other thread has the mutex locked, is O.K? It would be good to explain in the commit message why this is correct, because it is not obvious. Andrew