RE: [External Mail] Re: [PATCH v3 1/7] net: wwan: t9xx: Add PCIe core

Hi Andrew,

quoted

+#else /* !CONFIG_ACPI */
+	dev_err((mdev)->dev, "Unsupported, CONFIG ACPI hasn't been set to 'y'\n");

Why not just have the Kconfig depend on ACPI?

Will add "depends on ACPI" and remove the #ifdef blocks in v4.

quoted

+	if (ret) {
+		dev_err((mdev)->dev, "Failed to register mhccif_irq callback\n");

Why the () around mdev?

Will remove the unnecessary parentheses from all occurrences in v4.

Thanks.