On Fri, Jun 26, 2026 at 1:18 PM Victor Nogueira [off-list ref] wrote:

On 25/06/2026 06:51, Bryam Vargas via B4 Relay wrote:

quoted

From: Bryam Vargas <redacted>

multiq_dequeue() takes a packet from a band's child with a direct
->dequeue() call after multiq_peek() peeked it. When the child is
non-work-conserving the peek stashes the skb in the child's gso_skb, so
the direct dequeue returns a different skb and orphans the stash,
desyncing the child's qlen/backlog. With a qfq child reached through a
peeking parent (e.g. tbf) this re-enters the child on an emptied list and
dereferences NULL, panicking the kernel from softirq on ordinary egress.

Take the packet through qdisc_dequeue_peeked(), as sch_prio already does
and as sch_red and sch_sfb were just fixed to do. The helper is a no-op
when the child has no stash, so a work-conserving child is unaffected.

Fixes: 77be155cba4e ("pkt_sched: Add peek emulation for non-work-conserving qdiscs.")
Cc: stable@vger.kernel.org
Signed-off-by: Bryam Vargas <redacted>

Reviewed-by: Victor Nogueira <redacted>

Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>

cheers,
jamal