[PATCH net-next] fsl/fman: make enable() return void
From: Haoxiang Li <hidden>
Date: 2026-06-25 00:56:54
Also in:
lkml
Subsystem:
networking drivers, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
The enable() helper always returns 0 and has no failure path. Make it return void and update the only caller accordingly. Signed-off-by: Haoxiang Li <redacted> --- drivers/net/ethernet/freescale/fman/fman.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fman/fman.c b/drivers/net/ethernet/freescale/fman/fman.c
index 013273a2de32..aa35373413d4 100644
--- a/drivers/net/ethernet/freescale/fman/fman.c
+++ b/drivers/net/ethernet/freescale/fman/fman.c@@ -924,7 +924,7 @@ static void hwp_init(struct fman_hwp_regs __iomem *hwp_rg) iowrite32be(HWP_RPIMAC_PEN, &hwp_rg->fmprrpimac); } -static int enable(struct fman *fman, struct fman_cfg *cfg) +static void enable(struct fman *fman, struct fman_cfg *cfg) { u32 cfg_reg = 0;
@@ -941,8 +941,6 @@ static int enable(struct fman *fman, struct fman_cfg *cfg) iowrite32be(BMI_INIT_START, &fman->bmi_regs->fmbm_init); iowrite32be(cfg_reg | QMI_CFG_ENQ_EN | QMI_CFG_DEQ_EN, &fman->qmi_regs->fmqm_gc); - - return 0; } static int set_exception(struct fman *fman,
@@ -1998,9 +1996,7 @@ static int fman_init(struct fman *fman) if (!fman->keygen) return -EINVAL; - err = enable(fman, cfg); - if (err != 0) - return err; + enable(fman, cfg); enable_time_stamp(fman);
--
2.25.1