[PATCH net v4 0/2] net: phy: sfp/mdio-i2c: defer RollBall probe + fix mii_bus leak
From: Petr Wozniak <hidden>
Date: 2026-06-24 08:48:22
Also in:
linux-phy, lkml
This series resends the RollBall bridge probe deferral (a fix for the regression in commit 8fe125892f40) and adds a related mii_bus leak fix. Patch 1 fixes a pre-existing mii_bus leak in sfp_i2c_mdiobus_destroy() that has been present since the helper was introduced in 2022. Patch 2 introduces a new -ENODEV path that destroys the MDIO bus via sfp_i2c_mdiobus_destroy(), so patch 1 is a prerequisite to avoid leaking the bus on that path. v4: - Retargeted net-next -> net: both patches carry Fixes: tags and 8fe125892f40 is now in mainline. - Patch 1: added Reviewed-by: Maxime Chevallier. - Patch 2: reworked post-probe error handling to drop an over-80-column line and moved two block comment terminators to their own line (checkpatch); set err = 0 after switching to MDIO_I2C_NONE so the SFP state machine does not schedule a redundant 1 s retry. No functional change to the probe logic. v3: - Resend: v2 defer patch was corrupted in transit and failed to apply (netdev/apply); regenerated against current net-next. - Fixed block comment style flagged by checkpatch. No functional change. - Added patch 1/2 (sfp: free mii_bus in sfp_i2c_mdiobus_destroy). v2 (defer): - Generalized scope: regression affects boot-inserted and hotplugged modules where bridge init exceeds 200 ms; Aleksander Bajkowski confirmed FLYPRO SFP-10GT-CS-30M / AQR113C broken when hotplugged. - Corrected state machine description (probe runs in SFP_S_INIT after SFP_S_WAIT) - Jan Hoffmann. - No code changes from v1. v1: initial submission. Petr Wozniak (2): net: phy: sfp: free mii_bus in sfp_i2c_mdiobus_destroy net: phy: mdio-i2c: defer RollBall bridge probe to PHY discovery drivers/net/mdio/mdio-i2c.c | 15 +++++++++------ drivers/net/phy/sfp.c | 23 +++++++++++++++-------- include/linux/mdio/mdio-i2c.h | 1 + 3 files changed, 25 insertions(+), 14 deletions(-) -- 2.51.0