Thread (14 messages) 14 messages, 5 authors, 14d ago

Re: [PATCH net-next 0/3] selftests/xsk: stabilize timeout test behavior

From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Date: 2026-06-23 14:58:41
Also in: bpf

On Wed, Jun 17, 2026 at 11:43:14AM +0200, Maciej Fijalkowski wrote:
On Wed, Jun 17, 2026 at 07:39:06AM +0800, Jason Xing wrote:
quoted
Hi Tushar,

On Tue, Jun 16, 2026 at 11:50 PM Tushar Vyavahare
[off-list ref] wrote:
quoted
This series improves AF_XDP selftests by making timeout handling
explicit and fixing sources of non-determinism in xsk timeout tests.

Patch 1 introduces test_spec::poll_tmout and removes implicit
dependence on RX UMEM setup state for timeout behavior.

Patch 2 fixes thread harness sequencing by attaching XDP programs
before worker startup, removing signal-based termination, and using
barrier synchronization only for dual-thread runs.

Patch 3 restores shared_umem after POLL_TXQ_FULL so test-local
configuration does not leak into subsequent cases on shared-netdev
runs.

Together these changes make timeout handling easier to follow and
improve selftest stability, especially on real NIC runs.
net-next is closed, but in the meantime I'll review the series ASAP.

BTW, another thing about selftests I had in my mind is that are you
planning to work on this [1]?
This one is on me. I took your changes Jason and aligned ZC batching side
to this behavior, followed by xskxceiver adjustment. I am planning to send
this today EOD, however let's see how badly internal Sashiko will kick my
ass.
Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Tested-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
quoted
[1]: https://lore.kernel.org/all/20260520004244.55663-1-kerneljasonxing@gmail.com/ (local)

Thanks,
Jason
quoted
Tushar Vyavahare (3):
  selftests/xsk: make poll timeout mode explicit
  selftests/xsk: fix timeout thread harness sequencing
  selftests/xsk: restore shared_umem after POLL_TXQ_FULL

 .../selftests/bpf/prog_tests/test_xsk.c       | 96 +++++++++++--------
 .../selftests/bpf/prog_tests/test_xsk.h       |  2 +
 2 files changed, 56 insertions(+), 42 deletions(-)

--
2.43.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help