Re: [PATCH net 3/3] net/mlx5e: TC, skip peer flow cleanup when LAG seq is unavailable
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-06-23 00:03:56
Also in:
linux-rdma, lkml
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-06-23 00:03:56
Also in:
linux-rdma, lkml
On Mon, 22 Jun 2026 09:40:44 +0300 Shay Drori wrote:
quoted
[Severity: Critical] Does skipping the remainder of this loop prevent the flow from being unlinked from the doubly-linked list? By using continue here in mlx5e_tc_del_fdb_peers_flow(), we skip calling mlx5e_tc_del_fdb_peer_flow(), which means flow->peer[i] is never unlinked from the esw->offloads.peer_flows[original_i] list.only in case a LAG member is removed from ldev, mlx5_lag_get_dev_seq() will return error. before LAG member is removed, esw->devcom is cleanup, which invoke mlx5e_tc_clean_fdb_peer_flows(), which remove all peer flows. Hence, no flow remains.
Thanks for responding. That said, the series no longer applies. -- pw-bot: cr