Re: [PATCH net] net: sit: require CAP_NET_ADMIN in the device netns for changelink
From: Kuniyuki Iwashima <kuniyu@google.com>
Date: 2026-06-19 21:29:36
Also in:
lkml, stable
From: Kuniyuki Iwashima <kuniyu@google.com>
Date: 2026-06-19 21:29:36
Also in:
lkml, stable
On Thu, Jun 18, 2026 at 12:08 AM Maoyi Xie [off-list ref] wrote:
ipip6_changelink() operates on at most two netns, dev_net(dev) and the
tunnel link netns t->net. They differ once the device is created in or
moved to a netns other than the one the request runs in. The rtnl
changelink path checks CAP_NET_ADMIN only against dev_net(dev), so a
caller privileged there but not in t->net can rewrite a tunnel that
lives in t->net.
Gate ipip6_changelink() on rtnl_dev_link_net_capable() at its top,
before any attribute is parsed. sit was the one tunnel type not covered
by the recent series that added this check to the other changelink()
handlers.
Fixes: 5e6700b3bf98 ("sit: add support of x-netns")
Link: https://lore.kernel.org/netdev/20260612085941.3158249-1-maoyixie.tju@gmail.com/ (local)
Cc: stable@vger.kernel.org
Signed-off-by: Maoyi Xie <redacted>Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>