Thread (3 messages) 3 messages, 3 authors, 2026-06-21

Re: [PATCHv2] net: emac: Fix NULL pointer dereference in emac_probe

From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-06-18 08:03:44
Also in: lkml

On Wed, Jun 17, 2026 at 07:34:05PM -0700, Rosen Penev wrote:
Move devm_request_irq() after devm_platform_ioremap_resource() so that
dev->emacp is mapped before the interrupt handler can fire.  An early
interrupt hitting emac_irq() would dereference the NULL dev->emacp and
crash.

Also remove redundant error message. devm_platform_ioremap_resource()
already returns an error message with dev_err_probe().
I still think there is a bigger problem that interrupts can fire
early, but:

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help