Re: [PATCH v4 1/3] dt-bindings: net: add Realtek RTL8125 PCIe Ethernet
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: 2026-06-17 16:43:58
Also in:
linux-arm-kernel, linux-devicetree, linux-rockchip, lkml
On 17.06.2026 14:58, Ricardo Pardini via B4 Relay wrote:
quoted hunk ↗ jump to hunk
From: Ricardo Pardini <redacted> Add a binding for fixed/soldered Realtek RTL8125 PCIe Ethernet controller. The "pciVVVV,DDDD" compatibles are the Open Firmware PCI Bus Binding spelling, auto-derived from PCI-SIG vendor/device IDs, but they still need a binding when used in a board DT - analogous to "usbVVVV,PPPP" compatibles documented in their own bindings (e.g. microchip,lan95xx) so board DTs attaching properties (fixed MAC, nvmem cell, ...) to these PCI function nodes can be validated. Suggested-by: Sebastian Reichel <redacted> Signed-off-by: Ricardo Pardini <redacted> --- .../devicetree/bindings/net/realtek,rtl8125.yaml | 43 ++++++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 44 insertions(+)diff --git a/Documentation/devicetree/bindings/net/realtek,rtl8125.yaml b/Documentation/devicetree/bindings/net/realtek,rtl8125.yaml new file mode 100644 index 0000000000000..eee13fbc1e6a6 --- /dev/null +++ b/Documentation/devicetree/bindings/net/realtek,rtl8125.yaml@@ -0,0 +1,43 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/realtek,rtl8125.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Realtek RTL8125 2.5 Gigabit PCIe Ethernet Controller + +maintainers: + - Heiner Kallweit <hkallweit1@gmail.com> + +description: + The Realtek RTL8125 is a 2.5GBASE-T Ethernet controller with a PCIe host + interface. + +allOf: + - $ref: ethernet-controller.yaml# + +properties: + compatible: + const: pci10ec,8125
IIRC we came to the conclusion that the compatible string isn't used in the relevant code path. Then why add it here? Is there an alignment on this? If it should be added here, then an explaining comment would be helpful.
quoted hunk ↗ jump to hunk
+ + reg: + maxItems: 1 + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + pcie { + #address-cells = <3>; + #size-cells = <2>; + + ethernet@0,0 { + compatible = "pci10ec,8125"; + reg = <0x10000 0 0 0 0>; + local-mac-address = [00 00 00 00 00 00]; + }; + };diff --git a/MAINTAINERS b/MAINTAINERS index c8d4b913f26c1..e5fbd82946aec 100644 --- a/MAINTAINERS +++ b/MAINTAINERS@@ -134,6 +134,7 @@ M: Heiner Kallweit <hkallweit1@gmail.com> M: nic_swsd@realtek.com L: netdev@vger.kernel.org S: Maintained +F: Documentation/devicetree/bindings/net/realtek,rtl8125.yaml F: drivers/net/ethernet/realtek/r8169* 8250/16?50 (AND CLONE UARTS) SERIAL DRIVER