Thread (5 messages) 5 messages, 5 authors, 24d ago

Re: [PATCH net] selftests: vlan_bridge_binding: Fix flaky operational state check

From: Nikolay Aleksandrov <razor@blackwall.org>
Date: 2026-06-17 10:52:41

On 17/06/2026 13:43, Ido Schimmel wrote:
quoted hunk ↗ jump to hunk
check_operstate() busy waits for up to one second for the operational
state to change to the expected state. This is not enough since carrier
loss events can be delayed by the kernel for up to one second (see
__linkwatch_run_queue()), leading to sporadic failures.

Fix by increasing the busy wait period to two seconds.

Fixes: dca12e9ab760 ("selftests: net: Add a VLAN bridge binding selftest")
Reported-by: Jakub Kicinski <kuba@kernel.org>
Closes: https://lore.kernel.org/netdev/20260616092733.3a31be4d@kernel.org/ (local)
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
  tools/testing/selftests/net/vlan_bridge_binding.sh | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/vlan_bridge_binding.sh b/tools/testing/selftests/net/vlan_bridge_binding.sh
index e8c02c64e03a..d04caa14202d 100755
--- a/tools/testing/selftests/net/vlan_bridge_binding.sh
+++ b/tools/testing/selftests/net/vlan_bridge_binding.sh
@@ -64,7 +64,7 @@ check_operstate()
  	local expect=$1; shift
  	local operstate
  
-	operstate=$(busywait 1000 \
+	operstate=$(busywait 2000 \
  			operstate_is "$dev" "$expect")
  	check_err $? "Got operstate of $operstate, expected $expect"
  }
Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help