Re: [PATCH net-next v13 09/15] quic: add congestion control
flat view
From: Xin Long <lucien.xin@gmail.com>
Date: 2026-06-12 19:37:45
Also in:
linux-cifs
[sashiko-gemini]
quoted hunk ↗ jump to hunk
+ case QUIC_CONG_CONGESTION_AVOIDANCE: + /* cong->window is never zero; it is initialized by + * quic_packet_route() during connect/accept. + */ + cong->window += cong->mss * bytes / cong->window;
Can this arithmetic permanently stall congestion window growth or cause an overflow? Since all variables are 32-bit integers, the division could truncate to 0 as the window grows larger than cong->mss * bytes. Also, if bytes is large due to coalesced ACKs, could the multiplication wrap around U32_MAX? This looks a legit one, will confirm and fix it. Thanks.