Thread (9 messages) 9 messages, 3 authors, 26d ago

Re: [PATCH] net: macb: add TX stall timeout callback to recover from lost TSTART write

From: Nicolai Buchwitz <hidden>
Date: 2026-06-12 12:53:35
Also in: linux-arm-kernel, lkml

Hi Andrea

On 12.6.2026 14:51, Andrea della Porta wrote:
[...]
quoted
The commit message describes it as RP1 specific, but it gets applied 
to all
other variants?
I've seen this issue happening only on RaspberryPi 5, but AFAIK it
could affect also other MACB blocks connected through PCIe, so it
may be widespread (even though it should have probably already been
noticed in the past). In the orginal driver there's no timeout callback
defined and this is much like pretgending the issue causing the timeout
to happen to go away without doing anything (whatever the cause ot the
specific hw are). So in my opinion we can just extend that to all MACB.
Or maybe we should execute the restart conditionally on
.compatible = "raspberrypi,rp1-gem"?
I just observed the issue once, but other people reported it to be 
happen more
frequently. If we can narrow down a reproducer, it would be good to test 
on other
blocks too (like EyeQ at Théo's).|

So maybe you can imagine a good repro for this issue?

Thanks,
Nicolai
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help