[PATCH net-next 3/4] net: shaper: add a comment why we don't need kfree_rcu() in flush
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-06-09 18:32:27
Subsystem:
networking [general], the rest · Maintainers:
"David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
We keep getting misguided patches to fix the flush. Add a comment. Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- net/shaper/shaper.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/net/shaper/shaper.c b/net/shaper/shaper.c
index 33958462e5e9..5a3b44c5d10f 100644
--- a/net/shaper/shaper.c
+++ b/net/shaper/shaper.c@@ -1470,6 +1470,10 @@ static void net_shaper_flush(struct net_shaper_binding *binding) xa_for_each(&hierarchy->shapers, index, cur) { xa_erase(&hierarchy->shapers, index); + /* No need to use kfree_rcu(), netdev is already unpublished, + * and synchronize_rcu() has been run as part of + * unregister_netdevice(). + */ kfree(cur); }
--
2.54.0