Re: [PATCH v4] rust: make `build_assert` module the home of related macros

On Tue Jun 9, 2026 at 6:19 PM BST, Miguel Ojeda wrote:

On Tue, Jun 9, 2026 at 4:27 PM Gary Guo [off-list ref] wrote:

quoted

This is the remaining unapplied patch from
https://lore.kernel.org/rust-for-linux/20260319121653.2975748-1-gary@kernel.org/ (local).

Thanks for rebasing! I had it as "Waiting for apply" in the
spreadsheet, but this saved me a bit of work.

Quick question below about the prelude...

quoted

+#[doc(no_inline)]
+pub use crate::build_assert::{
+    build_assert,
+    build_error,
+    const_assert,
+    static_assert, //
+};

Did you split this for some reason? I moved the file to a single group
per crate when I moved the file to the new formatting style, so I was
wondering if we could keep it non-split. I mean, it may be nicer for
macros since it allows us to group them, but I hope we don't end up
with many `use`s again if we go down that road again...

I think I just kept it as is when rebasing. It's file to have them grouped in
the crate to.

Or perhaps you did it for the attribute, i.e. it may behave
differently, but I doubt that is the case? i.e. if `no_inline` somehow
behaves differently this way.

quoted

rust/kernel/sync/atomic/predefine.rs

In this one you used the prelude, but in the others not -- which is
fine, we should be using the prelude more (though perhaps it is a
separate change), but I wonder if there was a reason.

This one is using size_of, align_of, c_void which are all in prelude. However it
looks like I forgot to actually remove these imports in the last version, and I
didn't change it during rebase.

Are you okay with fixing during applying, or do you want me to send a new version?

Best,
Gary