Thread (4 messages) 4 messages, 4 authors, 5d ago

Re: [PATCH net] net: openvswitch: fix possible kfree_skb of ERR_PTR

From: patchwork-bot+netdevbpf@kernel.org
Date: 2026-06-09 03:20:07
Also in: lkml

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski [off-list ref]:

On Thu,  4 Jun 2026 14:19:46 +0200 you wrote:
After the patch in the "Fixes" tag, the allocation of the "reply" skb
can happen either before or after locking the ovs_mutex.

However, error cleanups still follow the classical reversed order,
assuming "reply" is allocated before locking: it is freed after unlocking.

If "reply" allocation happens after locking the mutex and it fails,
"reply" is left with an ERR_PTR, and execution jumps to the correspondent
cleanup stage which will try to free an invalid pointer.

[...]
Here is the summary with links:
  - [net] net: openvswitch: fix possible kfree_skb of ERR_PTR
    https://git.kernel.org/netdev/net/c/ee30dd2909d8

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help