Re: [PATCH net-next 2/2] selftests: drv-net: so_txtime: check IP versions
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: 2026-06-08 20:25:03
Jakub Kicinski wrote:
This test needs more work, and it fails in non-obvious way when IPv4 connectivity is not available: # Exception| CMD[remote]: /tmp/vjquwblf/gukinuzqso_txtime -4 -c mono -t 1780939014114542914 -S None -D None a,0 -r # Exception| EXIT: -15 Explicitly check for IPv4 support to make the future triage less painful. Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Willem de Bruijn <willemb@google.com> but two comments FYI:
quoted hunk ↗ jump to hunk
--- tools/testing/selftests/drivers/net/so_txtime.py | 2 ++ 1 file changed, 2 insertions(+)diff --git a/tools/testing/selftests/drivers/net/so_txtime.py b/tools/testing/selftests/drivers/net/so_txtime.py index ddcd2c0e06a8..8fe061f52055 100755 --- a/tools/testing/selftests/drivers/net/so_txtime.py +++ b/tools/testing/selftests/drivers/net/so_txtime.py@@ -64,6 +64,7 @@ from lib.py import NetDrvEpEnv, bkg, cmd, defer, tc @ksft_variants(_test_variants_mono()) def test_so_txtime_mono(cfg, ipver, args_tx, args_rx): """Run all variants of monotonic (fq) tests.""" + cfg.require_ipver(ipver)
This may cause aconflict with my outstanding SO_TXTIME series. And more importantly miss having it in the new test_so_txtime_fq_tai variant. Could this test be moved to test_so_txtime that all of them call? (there is WIP to add another mono_hw variant too)
quoted hunk ↗ jump to hunk
_qdisc_setup(cfg.ifname, "fq") test_so_txtime(cfg, "mono", ipver, args_tx, args_rx, True)@@ -86,6 +87,7 @@ from lib.py import NetDrvEpEnv, bkg, cmd, defer, tc @ksft_variants(_test_variants_etf()) def test_so_txtime_etf(cfg, ipver, args_tx, args_rx, expect_fail): """Run all variants of etf tests.""" + cfg.require_ipver(ipver) try: _qdisc_setup(cfg.ifname, "etf", "clockid CLOCK_TAI delta 400000") except Exception as e:-- 2.54.0