Re: [PATCH bpf v8 2/2] selftests/bpf: Add protocol check test for bpf_sk_assign_tcp_reqsk()
From: bot+bpf-ci@kernel.org
Date: 2026-06-08 13:31:49
Also in:
bpf, linux-kselftest, lkml
quoted hunk ↗ jump to hunk
diff --git a/tools/testing/selftests/bpf/prog_tests/tcp_custom_syncookie.c b/tools/testing/selftests/bpf/prog_tests/tcp_custom_syncookie.c index eaf441dc7e79..b644acd3e903 100644 --- a/tools/testing/selftests/bpf/prog_tests/tcp_custom_syncookie.c +++ b/tools/testing/selftests/bpf/prog_tests/tcp_custom_syncookie.c
[ ... ]
quoted hunk ↗ jump to hunk
@@ -145,6 +145,85 @@ void test_tcp_custom_syncookie(void) destroy_skel: system("tc qdisc del dev lo clsact"); + test_tcp_custom_syncookie__destroy(skel); +} + +/* TCP and UDP servers share the same port. The BPF program intercepts
The BPF subsystem style guidelines ask that the opening /* of a multi-line comment be on its own line. Should this be: /* * TCP and UDP servers share the same port. The BPF program intercepts * the UDP packet, looks up the TCP listener via the dest port, and * attempts to assign a TCP reqsk to the UDP skb. ... */ The same nit was raised on v8 by the automated review at: https://lore.kernel.org/bpf/20260608130746.218891F00898@smtp.kernel.org (local)
+ * the UDP packet, looks up the TCP listener via the dest port, and + * attempts to assign a TCP reqsk to the UDP skb. + * Although bpf_sk_assign_tcp_reqsk() assign udp skb to tcp reqsk, the + * network stack should not crash. + */
--- AI reviewed your patch. Please fix the bug or email reply why it's not a bug. See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md CI run summary: https://github.com/kernel-patches/bpf/actions/runs/27139886597