[PATCH net-next v08 5/5] hinic3: Remove unneeded coalesce parameters
From: Fan Gong <gongfan1@huawei.com>
Date: 2026-06-08 12:36:52
Also in:
linux-doc, lkml
Subsystem:
huawei 3rd gen ethernet driver, networking drivers, the rest · Maintainers:
Fan Gong, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Remove unneeded coalesce parameters in irq handling. Co-developed-by: Wu Di <redacted> Signed-off-by: Wu Di <redacted> Co-developed-by: Teng Peisen <redacted> Signed-off-by: Teng Peisen <redacted> Signed-off-by: Fan Gong <gongfan1@huawei.com> --- drivers/net/ethernet/huawei/hinic3/hinic3_irq.c | 6 +----- drivers/net/ethernet/huawei/hinic3/hinic3_rx.h | 3 --- 2 files changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_irq.c b/drivers/net/ethernet/huawei/hinic3/hinic3_irq.c
index b7cd5f2f53a7..6a8695e0a69a 100644
--- a/drivers/net/ethernet/huawei/hinic3/hinic3_irq.c
+++ b/drivers/net/ethernet/huawei/hinic3/hinic3_irq.c@@ -149,13 +149,9 @@ static int hinic3_set_interrupt_moder(struct net_device *netdev, u16 q_id, nic_dev->intr_coalesce[q_id].resend_timer_cfg; err = hinic3_set_interrupt_cfg(nic_dev->hwdev, info); - if (err) { + if (err) netdev_err(netdev, "Failed to modify moderation for Queue: %u\n", q_id); - } else { - nic_dev->rxqs[q_id].last_coalesc_timer_cfg = coalesc_timer_cfg; - nic_dev->rxqs[q_id].last_pending_limit = pending_limit; - } mutex_unlock(&nic_dev->change_res_mutex);
diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_rx.h b/drivers/net/ethernet/huawei/hinic3/hinic3_rx.h
index c11d080408a7..2ab691ed11a9 100644
--- a/drivers/net/ethernet/huawei/hinic3/hinic3_rx.h
+++ b/drivers/net/ethernet/huawei/hinic3/hinic3_rx.h@@ -111,9 +111,6 @@ struct hinic3_rxq { dma_addr_t cqe_start_paddr; struct dim dim; - - u8 last_coalesc_timer_cfg; - u8 last_pending_limit; } ____cacheline_aligned; struct hinic3_dyna_rxq_res {
--
2.43.0