Thread (6 messages) 6 messages, 3 authors, 9d ago
COOLING9d
Revisions (2)
  1. v2 [diff vs current]
  2. v3 current

[PATCH net v3 0/3] net: txgbe: fix module identification

From: Jiawen Wu <jiawenwu@trustnetic.com>
Date: 2026-06-08 07:10:03

For AML devices, there are some issues where the wrong module
indentified then configure PHY failed.

The module info buffers should be initialized to 0 before the firmware
returns information. And DECLARE_PHY_INTERFACE_MASK() does not guarantee
zeroed contents, so explicitly clear the temporary interface masks before
setting supported interfaces.

Rework txgbe_identify_module() to validate module identifiers through
explicit type checks instead of relying on transceiver_type heuristics.
When using the SFP module, transceiver_type could be a random value,
because it was read from an invalid register.

---
Changes log:
v3:
- Add a new macro DECLARE_PHY_INTERFACE_MASK_ZEROED().

v2: https://lore.kernel.org/all/20260605030850.17796-1-jiawenwu@trustnetic.com (local)
- Split the patch into 3 fixes.
- Change DECLARE_PHY_INTERFACE_MASK() to empty array.

v1: https://lore.kernel.org/all/F3DA1ECDCE0A1E9E+20260602025443.332456-1-jiawenwu@trustnetic.com (local)
---

Jiawen Wu (3):
  net: txgbe: initialize module info buffer
  net: txgbe: distinguish module types by checking identifier
  net: txgbe: initialize PHY interface to 0

 .../net/ethernet/wangxun/txgbe/txgbe_aml.c    | 24 +++++++++----------
 .../net/ethernet/wangxun/txgbe/txgbe_type.h   |  3 +++
 2 files changed, 14 insertions(+), 13 deletions(-)

-- 
2.51.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help