Re: [net-next PATCH v13 0/9] net: dsa: realtek: rtl8365mb: bridge offloading and VLAN support
From: Luiz Angelo Daros de Luca <hidden>
Date: 2026-06-08 03:43:56
Also in:
lkml
From: Luiz Angelo Daros de Luca <hidden>
Date: 2026-06-08 03:43:56
Also in:
lkml
Sashikos' results are out: https://sashiko.dev/#/patchset/20260606-realtek_forward-v13-0-b9e409687cbe%40gmail.com (Gemini) After a few versions without comments, it now added a single comment on patch 7 (FDB). In that comment, it misses the fact that the DSA core already keeps track of multicast usage for shared ports (CPU, link). https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260606-realtek_forward-v13-0-b9e409687cbe%40gmail.com (Opus) It commented about vlan_lock not being used by rtl8366rb and that it should be moved to the rtl8365mb private struct. However, rtl8366rb might indeed require the same lock, as the concurrency issues are mostly the same for both drivers. It also complained about a couple of unused macros, which do little harm and help document the registers. There is also an error message comment that I would consider if v14 is required. While using stringify, it will print the vlan id limits in hexadecimal, whereas the decimal format would be more user-friendly. From both reviews (and the history of them for older versions), I see no blocker for merging. Regards, Luiz