Thread (12 messages) 12 messages, 3 authors, 27d ago

Re: [PATCH net-next v3 4/4] net: phy: realtek: load firmware for RTL8261C_CG

From: Nicolai Buchwitz <hidden>
Date: 2026-06-05 09:11:53
Also in: lkml

Hi Javen

On 5.6.2026 09:43, javen wrote:
From: Javen Xu <redacted>

This patch adds support for loading firmware. Download some parameters
for RTL8261C_CG.

Signed-off-by: Javen Xu <redacted>
---
Changes in v2:
 - remove __pack, struct rtl8261x_fw_header and rtl8261x_fw_entry will 
not pad
 - reverse xmas tree for some definition
 - add explanation on rtl_phy_write_mmd_bits()

Changes in v3:
 - add struct rtl8261x_priv
---
[...]
+static int rtl8261x_config_init(struct phy_device *phydev)
+{
+	struct rtl8261x_priv *priv = phydev->priv;
+	int ret = 0;
+
+	if (priv->fw_name && !priv->fw_loaded) {
+		ret = rtl8261x_fw_load(phydev);
+		if (ret) {
+			phydev_err(phydev, "Firmware loading failed: %d\n", ret);
+			return ret;
+		}
+	}
fw_loaded loads once per lifetime, phy_init_hw() does soft_reset before 
config_init.
So after a reset (e.g. resume), aren't the patches gone and never 
re-applied?
en8811h for example re-runs every config_init - but just guessing as I 
don't know
the internals of your fw.
[...]
Thanks,
Nicolai
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help