Thread (5 messages) 5 messages, 5 authors, 2026-06-05

Re: [PATCH net-next v1 1/1] net: dsa: realtek: Use %pM format specifier for MAC addresses

From: Nicolai Buchwitz <hidden>
Date: 2026-06-03 12:38:33
Also in: lkml

On 3.6.2026 13:20, Andy Shevchenko wrote:
quoted hunk ↗ jump to hunk
Convert to %pM instead of using custom code.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/net/dsa/realtek/rtl8366rb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/dsa/realtek/rtl8366rb.c 
b/drivers/net/dsa/realtek/rtl8366rb.c
index d96ae72b0a5c..103039fe3086 100644
--- a/drivers/net/dsa/realtek/rtl8366rb.c
+++ b/drivers/net/dsa/realtek/rtl8366rb.c
@@ -573,8 +573,7 @@ static int rtl8366rb_set_addr(struct realtek_priv 
*priv)

 	eth_random_addr(addr);

-	dev_info(priv->dev, "set MAC: %02X:%02X:%02X:%02X:%02X:%02X\n",
-		 addr[0], addr[1], addr[2], addr[3], addr[4], addr[5]);
+	dev_info(priv->dev, "set MAC: %pM\n", addr);
 	val = addr[0] << 8 | addr[1];
 	ret = regmap_write(priv->map, RTL8366RB_SMAR0, val);
 	if (ret)
Reviewed-by: Nicolai Buchwitz <redacted>

Thanks
Nicolai
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help