Re: [PATCH] rtase: Avoid sleeping in get_stats64()

From
David Laight <hidden>
Date
2026-06-03 09:59:33
Also in
lkml
Reply to
Alexander Lobakin, 2026-06-02
On Tue, 2 Jun 2026 15:43:04 +0200
Alexander Lobakin [off-list ref] wrote:
From: David Laight <redacted>
Date: Mon, 1 Jun 2026 22:42:03 +0100
quoted
On Mon, 1 Jun 2026 15:14:50 +0200
Alexander Lobakin [off-list ref] wrote:
  
quoted
From: Justin Lai <justinlai0215@realtek.com>
Date: Mon, 1 Jun 2026 14:24:47 +0800
 
quoted
The .ndo_get_stats64 callback must not sleep because it can be
called when reading /proc/net/dev.

rtase_get_stats64() calls rtase_dump_tally_counter(), which polls
the tally counter dump bit with read_poll_timeout(). This may
sleep while waiting for the hardware counter dump to complete.

Use read_poll_timeout_atomic() instead to avoid sleeping in the
get_stats64() path.

Signed-off-by: Justin Lai <justinlai0215@realtek.com>    
Looks legit.

One question: for how long can this poll for in real life scenarios? Up
to ~1 ms is okay-ish for atomic, but if longer, then you'd better to
split it into shorter polls and reschedule() time to time.  
Anyone trying to get a thread running at an RT priority won't thank you
for spinning for anywhere near that long.
When an RT processes becomes runnable the scheduler will preempt a lower
priority process that is running on the cpu the RT process last ran on.
The RT process won't run until the preempt actually happens.

1ms is a very long time.  
That's why I wrote "okay-ish". Ideally atomic polling should not go past
100 us, I usually used it for no longer than 10-50 us.

The author says that it usually takes around 25 us which is acceptable
I'd say.
Just about :-)

Would anyone notice if the read stats code returned slightly old values
and did a async request to get the current ones?

Probably more work for a back-port though.

-- David
Thanks,
Olek
  
Thread (9 messages) 9 messages, 4 authors, last reply 2026-06-03
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help