On Mon, 11 May 2026 15:17:56 +0200 Stefano Garzarella wrote:

quoted

quoted

Okay, I thought it over over the weekend, and I agree that this patch
still doesn't solve the problem and would still result in packet loss.
So, until we resolve the issue permanently, and since 059b7dbd20a6 is
coming to stable, I'd like to rework this patch so that we only start
dropping packets when the overhead plus the queued bytes exceeds
`buf_alloc * 2`.
Removing the other changes to reduce the buf_alloc advertised, but
terminating the connection so that both peers are aware that something
went wrong.

Any objections?

Stefano  

Let's try to first fix it upstream properly please. Discuss backporting
later.  

Commit 059b7dbd20a6 ("vsock/virtio: fix potential unbounded skb
queue") is already in Linus tree and will land soon on stable. Which
issue do you see on having a patch on top of that to close the
connection instead of losing data and breaking our test suite?

IMO we need that change in any case, because the previous code also
discarded packets without any notification, whereas breaking the
connection would be better in that case.

Sorry if I'm speaking out of turn or misunderstanding but, like Michael
says, let's focus on fixing this the way we want it to be fixed?
IIUC you are trying to minimize the size of the fix, please don't worry
about the LoC in the diff at this stage.